Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45860 )
Change subject: mb/google/volteer: Add a DPTF policy for Eldrid ......................................................................
Patch Set 22:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45860/22/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45860/22/src/mainboard/google/volte... PS22, Line 79: register "policies.passive[0]" = "DPTF_PASSIVE(CPU,CPU,95,5000)" : register "policies.passive[3]" = "DPTF_PASSIVE(CPU,TEMP_SENSOR_2,60,6000)" Sorry Nick, I got myself confused the other day 😞
To override just the CPU and TEMP_SENSOR_2, this needs to be: ``` ## Passive Policy register "policies.passive" = "{ [0] = DPTF_PASSIVE(CPU, CPU, 95, 5000), [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 60, 6000), [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}"
```
https://review.coreboot.org/c/coreboot/+/45860/22/src/mainboard/google/volte... PS22, Line 82: ## Critical Policy : register "policies.critical[0]" = "DPTF_CRITICAL(CPU,100,SHUTDOWN)" : register "policies.critical[3]" = "DPTF_CRITICAL(TEMP_SENSOR_2,80,SHUTDOWN)" I apologize, the same thing here: ``` ## Critical Policy register "policies.critical" = "{ [0] = DPTF_CRITICAL(CPU, 100, SHUTDOWN), [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 75, SHUTDOWN), [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 75, SHUTDOWN), [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 80, SHUTDOWN), [4] = DPTF_CRITICAL(TEMP_SENSOR_3, 75, SHUTDOWN)}" ```