View Change

2 comments:

• File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

  • Patch Set #22, Line 79:

    				register "policies.passive[0]" = "DPTF_PASSIVE(CPU,CPU,95,5000)"
    				register "policies.passive[3]" = "DPTF_PASSIVE(CPU,TEMP_SENSOR_2,60,6000)"
    

    Sorry Nick, I got myself confused the other day 😞

    To override just the CPU and TEMP_SENSOR_2, this needs to be:
    ```
    ## Passive Policy
    register "policies.passive" = "{                                                                                                                                                                                                                     
            [0] = DPTF_PASSIVE(CPU,     CPU,           95, 5000),                                                                                                                                                                                        
            [1] = DPTF_PASSIVE(CPU,     TEMP_SENSOR_1, 65, 6000),                                                                                                                                                                                        
            [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000),                                                                                                                                                                                        
            [3] = DPTF_PASSIVE(CPU,     TEMP_SENSOR_2, 60, 6000),                                                                                                                                                                                        
            [4] = DPTF_PASSIVE(CPU,     TEMP_SENSOR_3, 65, 6000)}"

    ```

  • Patch Set #22, Line 82:

    				## Critical Policy
    				register "policies.critical[0]" = "DPTF_CRITICAL(CPU,100,SHUTDOWN)"
    				register "policies.critical[3]" = "DPTF_CRITICAL(TEMP_SENSOR_2,80,SHUTDOWN)"
    

    I apologize, the same thing here:
    ```
    ## Critical Policy
    register "policies.critical" = "{                                                                                                                                                                                                                    
            [0] = DPTF_CRITICAL(CPU,               100, SHUTDOWN),                                                                                                                                                                                       
            [1] = DPTF_CRITICAL(TEMP_SENSOR_0,      75, SHUTDOWN),                                                                                                                                                                                       
            [2] = DPTF_CRITICAL(TEMP_SENSOR_1,      75, SHUTDOWN),                                                                                                                                                                                       
            [3] = DPTF_CRITICAL(TEMP_SENSOR_2,      80, SHUTDOWN),                                                                                                                                                                                       
            [4] = DPTF_CRITICAL(TEMP_SENSOR_3,      75, SHUTDOWN)}"
    ```

To view, visit change 45860. To unsubscribe, or for help writing mail filters, visit settings.