Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )
Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33250/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33250/10//COMMIT_MSG@9 PS10, Line 9: Autogen Feature autogen feeater
https://review.coreboot.org/c/coreboot/+/33250/10//COMMIT_MSG@9 PS10, Line 9: Template template
https://review.coreboot.org/c/coreboot/+/33250/10//COMMIT_MSG@10 PS10, Line 10: Hmm, that is the commit message summary repeated. What is the autogen feature?
https://review.coreboot.org/c/coreboot/+/33250/10/src/superio/aspeed/common/... File src/superio/aspeed/common/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/33250/10/src/superio/aspeed/common/... PS10, Line 3: * One line? Missing author names?