Change in ...coreboot[master]: src/superio/aspeed/common: Add ACPI Template for Autogen Feature

List overview All Threads
Download

newer

older

Change in coreboot[master]: dram:...

Christian Walter (Code Review)

6 Jun 2019 6 Jun '19

8:27 a.m.

Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33250

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Add ACPI Template for Autogen Feature.

Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934 Signed-off-by: Christian Walter christian.walter@9elements.com --- A src/superio/aspeed/common/acpi/superio.asl 1 file changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/33250/1

diff --git a/src/superio/aspeed/common/acpi/superio.asl b/src/superio/aspeed/common/acpi/superio.asl new file mode 100644 index 0000000..6b8b8f6 --- /dev/null +++ b/src/superio/aspeed/common/acpi/superio.asl @@ -0,0 +1,21 @@ +## +## This file is part of the coreboot project. +## +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; either version 2 of the License, or +## (at your option) any later version. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +Device (SIO0) +{ + Name (_HID, EisaId ("PNP0C02") /* PNP Motherboard Resources */) // _HID: Hardware ID + Name (_UID, Zero) // _UID: Unique ID + +} \ No newline at end of file

Attachments:

attachment.htm (text/html — 3.9 KB)

Show replies by date

Philipp Deppenwiese (Code Review)

6 Jun 6 Jun

8:33 a.m.

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

Patch Set 1: Code-Review+2

Christian Walter (Code Review)

9 a.m.

Hello Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33250

to look at the new patch set (#3).

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Add ACPI Template for Autogen Feature.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/33250/3

Christian Walter (Code Review)

9:07 a.m.

Hello Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33250

to look at the new patch set (#4).

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Add ACPI Template for Autogen Feature.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/33250/4

Felix Held (Code Review)

7 Jun 7 Jun

4:29 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

Patch Set 5: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/33250/5/src/superio/aspeed/common/acpi/super... File src/superio/aspeed/common/acpi/superio.asl:

https://review.coreboot.org/#/c/33250/5/src/superio/aspeed/common/acpi/super... PS5, Line 18: Name (_HID, EisaId ("PNP0C02") /* PNP Motherboard Resources */) // _HID: Hardware ID this is a bit odd mix of comment styles

-- To view, visit https://review.coreboot.org/c/coreboot/+/33250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 5 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 07 Jun 2019 19:29:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

2 Jul 2 Jul

9:26 a.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

Patch Set 6:

Are you still planning to address the mixed comment style in one line issue? That's the only reason why I'm here a bit hesitant to +2 the patch; otherwise it looks good to me

-- To view, visit https://review.coreboot.org/c/coreboot/+/33250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 6 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jul 2019 12:26:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

19 Jul 19 Jul

9:54 a.m.

New subject: Change in coreboot[master]: src/superio/aspeed/common: Add ACPI Template for Autogen Feature

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33250/8/src/superio/aspeed/common/a... File src/superio/aspeed/common/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/33250/8/src/superio/aspeed/common/a... PS8, Line 18: /* PNP Motherboard Resources */ remove ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 8 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 19 Jul 2019 12:54:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Christian Walter (Code Review)

12:59 p.m.

New subject: Change in coreboot[master]: src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Hello Felix Held, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33250

to look at the new patch set (#9).

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Add ACPI Template for Autogen Feature.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/33250/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/33250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 9 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Felix Held (Code Review)

1:02 p.m.

New subject: Change in coreboot[master]: src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

Patch Set 9: Code-Review+2

(2 comments)

...

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33250/5/src/superio/aspeed/common/a... File src/superio/aspeed/common/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/33250/5/src/superio/aspeed/common/a... PS5, Line 18: Name (_HID, EisaId ("PNP0C02") /* PNP Motherboard Resources */) // _HID: Hardware ID

...

this is a bit odd mix of comment styles

Done

https://review.coreboot.org/c/coreboot/+/33250/8/src/superio/aspeed/common/a... File src/superio/aspeed/common/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/33250/8/src/superio/aspeed/common/a... PS8, Line 18: /* PNP Motherboard Resources */

...

remove ?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 9 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 19 Jul 2019 16:02:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Paul Menzel (Code Review)

22 Jul 22 Jul

12:24 p.m.

New subject: Change in coreboot[master]: src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

Patch Set 10:

(4 comments)

https://review.coreboot.org/c/coreboot/+/33250/10//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/33250/10//COMMIT_MSG@9 PS10, Line 9: Autogen Feature autogen feeater

https://review.coreboot.org/c/coreboot/+/33250/10//COMMIT_MSG@9 PS10, Line 9: Template template

https://review.coreboot.org/c/coreboot/+/33250/10//COMMIT_MSG@10 PS10, Line 10: Hmm, that is the commit message summary repeated. What is the autogen feature?

https://review.coreboot.org/c/coreboot/+/33250/10/src/superio/aspeed/common/... File src/superio/aspeed/common/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/33250/10/src/superio/aspeed/common/... PS10, Line 3: * One line? Missing author names?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 10 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 22 Jul 2019 15:24:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Christian Walter (Code Review)

24 Jul 24 Jul

9:43 a.m.

New subject: Change in coreboot[master]: src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Hello Felix Held, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33250

to look at the new patch set (#12).

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Add ACPI template for autogen feature.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/33250/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/33250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 12 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Christian Walter (Code Review)

25 Jul 25 Jul

4:58 a.m.

New subject: Change in coreboot[master]: src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

Patch Set 12:

(4 comments)

https://review.coreboot.org/c/coreboot/+/33250/10//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/33250/10//COMMIT_MSG@9 PS10, Line 9: Autogen Feature

...

autogen feeater

Done

https://review.coreboot.org/c/coreboot/+/33250/10//COMMIT_MSG@9 PS10, Line 9: Template

...

template

Done

https://review.coreboot.org/c/coreboot/+/33250/10//COMMIT_MSG@10 PS10, Line 10:

...

Hmm, that is the commit message summary repeated. […]

Done

https://review.coreboot.org/c/coreboot/+/33250/10/src/superio/aspeed/common/... File src/superio/aspeed/common/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/33250/10/src/superio/aspeed/common/... PS10, Line 3: *

...

One line? Missing author names?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 12 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 25 Jul 2019 07:58:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

9:38 a.m.

New subject: Change in coreboot[master]: src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

Patch Set 12:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33250/12//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/33250/12//COMMIT_MSG@7 PS12, Line 7: src/superio/aspeed/common: Add ACPI Template for Autogen Feature Please remove `src` at the beginning. The description also not very understandable in my opinion.

...

superio/aspeed: Add ACPI declarations

With the minimal ASL file, coreboot will autogenerate the necessary ACPI entries(?).

Please also add how you tested this.

https://review.coreboot.org/c/coreboot/+/33250/12/src/superio/aspeed/common/... File src/superio/aspeed/common/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/33250/12/src/superio/aspeed/common/... PS12, Line 18: Name (_HID, EisaId ("PNP0C02") ) // _HID: Hardware ID That’s the ID for the environment controller?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 12 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 25 Jul 2019 12:38:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

7 Aug 7 Aug

5:57 a.m.

New subject: Change in coreboot[master]: src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

Patch Set 12:

No longer needed with #33033

-- To view, visit https://review.coreboot.org/c/coreboot/+/33250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 12 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 07 Aug 2019 08:57:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Christian Walter (Code Review)

5:57 a.m.

New subject: Change in coreboot[master]: src/superio/aspeed/common: Add ACPI Template for Autogen Feature

Christian Walter has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33250 )

Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................

Abandoned

No longer needed with #33033

-- To view, visit https://review.coreboot.org/c/coreboot/+/33250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 12 Gerrit-Owner: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1756

days inactive

1818

days old

coreboot-gerrit@coreboot.org

14 comments

6 participants

tags (0)

participants (6)

Christian Walter (Code Review)
Felix Held (Code Review)
HAOUAS Elyes (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)
Philipp Deppenwiese (Code Review)