build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38349 )
Change subject: util/pmh7tool: support OpenBSD ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/c/coreboot/+/38349/1/util/pmh7tool/pmh7tool.c File util/pmh7tool/pmh7tool.c:
https://review.coreboot.org/c/coreboot/+/38349/1/util/pmh7tool/pmh7tool.c@30 PS1, Line 30: static uint8_t inb(unsigned port) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/38349/1/util/pmh7tool/pmh7tool.c@33 PS1, Line 33: __asm volatile("inb %w1,%0" : "=a" (data) : "d" (port)); Prefer using '"%s...", __func__' to using 'inb', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/38349/1/util/pmh7tool/pmh7tool.c@36 PS1, Line 36: static __inline void outb(uint8_t data, unsigned port) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/38349/1/util/pmh7tool/pmh7tool.c@36 PS1, Line 36: static __inline void outb(uint8_t data, unsigned port) plain inline is preferred over __inline
https://review.coreboot.org/c/coreboot/+/38349/1/util/pmh7tool/pmh7tool.c@38 PS1, Line 38: __asm volatile("outb %0,%w1" : : "a" (data), "d" (port)); Prefer using '"%s...", __func__' to using 'outb', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/38349/1/util/pmh7tool/pmh7tool.c@21... PS1, Line 214: if (iopl(3)) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38349/1/util/pmh7tool/pmh7tool.c@21... PS1, Line 214: if (iopl(3)) { suspect code indent for conditional statements (4, 16)