7 comments:
File util/pmh7tool/pmh7tool.c:
Patch Set #1, Line 30: static uint8_t inb(unsigned port)
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 33: __asm volatile("inb %w1,%0" : "=a" (data) : "d" (port));
Prefer using '"%s...", __func__' to using 'inb', this function's name, in a string
Patch Set #1, Line 36: static __inline void outb(uint8_t data, unsigned port)
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 36: static __inline void outb(uint8_t data, unsigned port)
plain inline is preferred over __inline
Patch Set #1, Line 38: __asm volatile("outb %0,%w1" : : "a" (data), "d" (port));
Prefer using '"%s...", __func__' to using 'outb', this function's name, in a string
Patch Set #1, Line 214: if (iopl(3)) {
please, no spaces at the start of a line
Patch Set #1, Line 214: if (iopl(3)) {
suspect code indent for conditional statements (4, 16)
To view, visit change 38349. To unsubscribe, or for help writing mail filters, visit settings.