[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Configure L1Substates for PCH Root ports

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39412 )

Change subject: soc/intel/tigerlake: Configure L1Substates for PCH Root ports
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39412/1/src/soc/intel/tigerlake/chi... 
File src/soc/intel/tigerlake/chip.h:

https://review.coreboot.org/c/coreboot/+/39412/1/src/soc/intel/tigerlake/chi... 
PS1, Line 126: 4:Max
> Can you please update the comment here to make it clear: […]

Function should actually be:

int get_l1_substate_control(enum L1_substates_control ctl)
{
    if ((ctl > L1_SS_L1_2) || (ctl == L1_SS_FSP_DEFAULT))
    	ctl = L1_SS_L1_2;
    
    /* .... Use same comment as above for enum .... */
    return ctl - 1;
}