Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37643 )
Change subject: Documentation: Add proposal for firmware testing ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... File Documentation/technotes/2019-12-firmware-testing.md:
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... PS3, Line 39: So these are
"So these are ... Requirement 1 ... and ... […]
Done
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... PS3, Line 63: Requirement
Does it include things like IFD or ME? […]
That's really orthogonal to the test tool itself. Clarified that getting an image is out of scope of testing.
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... PS3, Line 70: Requirement
I don't see that being useful. It only adds complexity in the dispatcher.
It's mostly "if test X didn't succeed, don't bother with tests Y and Z (because they're bound to fail)". Rephrased it.
https://review.coreboot.org/c/coreboot/+/37643/3/Documentation/technotes/201... PS3, Line 106: The language should be popular and the implementation robust.
I styled the doc in having prose explaining the properties and with requirements extracted from them […]
Rephrased it here to provide some more motivation _why_ requirement 9 is desirable.
https://review.coreboot.org/c/coreboot/+/37643/4/Documentation/technotes/201... File Documentation/technotes/2019-12-firmware-testing.md:
https://review.coreboot.org/c/coreboot/+/37643/4/Documentation/technotes/201... PS4, Line 10: (
Issues with LAVA: […]
Thanks, I added this.