Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8 ......................................................................
Patch Set 36:
(2 comments)
I created a new CL to deal with the exception issue. I updated ramdetect.c to register an exception handler and modified existing code to comply with the clang-format rules. Let's move on to the CL to discuss exception issues. https://review.coreboot.org/c/coreboot/+/34774
https://review.coreboot.org/c/coreboot/+/33387/33/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/exception.c:
https://review.coreboot.org/c/coreboot/+/33387/33/src/mainboard/emulation/qe... PS33, Line 19: return EXC_RET_IGNORED;
No, you should only have one exception handler. […]
Thank you for your code. I now understand how I can deal with an exception handler.
I don't change ramdetect.c in this CL, so created a new patch. https://review.coreboot.org/c/coreboot/+/34774
https://review.coreboot.org/c/coreboot/+/33387/35/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/include/mainboard/exception.h:
https://review.coreboot.org/c/coreboot/+/33387/35/src/mainboard/emulation/qe... PS35, Line 1: /*
If you're leaving the exception stuff for another patch then please remove this file.
This is the file I forgot to delete. Thank you for pointing out!