[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8183: do TX tracking for DRAM DVFS feature

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37996 )

Change subject: soc/mediatek/mt8183: do TX tracking for DRAM DVFS feature
......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37996/9/src/soc/mediatek/mt8183/dra... 
File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:

https://review.coreboot.org/c/coreboot/+/37996/9/src/soc/mediatek/mt8183/dra... 
PS9, Line 2139: 	while (!wait_us(10, read32(&ch[chn].nao.spcmdresp) & (0x1 << 10))) {
> Sorry for the late replay. […]

Paul, wait_us() is a convenience wrapper around the stopwatch framework (see https://review.coreboot.org/cgit/coreboot.git/tree/src/include/timer.h#n200) that is designed specifically for situations like this. It is the preferred way of handling "wait for a state change or timeout" cases like this.

And, yes, it should just be

if (!wait_us(100, ...))
   dramc_err(...);

There's no need to put another loop around it.