Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47432 )
Change subject: mb/google/dedede: Add the CSE RW firmware version
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47432/5/src/mainboard/google/dedede...
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/47432/5/src/mainboard/google/dedede...
PS5, Line 108: SOC_INTEL_CSE_RW_VERSION
I think it would be better to set this in config. […]
+1 to adding it in chromiumos-overlay. Also helps to avoid the downstreaming latency.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47432
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d0291aef97e2aab2334f62227083f3c32b85617
Gerrit-Change-Number: 47432
Gerrit-PatchSet: 5
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Nov 2020 23:10:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment