V Sowmya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47432 )
Change subject: mb/google/dedede: Add the CSE RW firmware version ......................................................................
mb/google/dedede: Add the CSE RW firmware version
This patch adds the CSE RW firmware version for dedede baseboard. * CSE_RW_VERSION = 13.50.0.1174
Change-Id: I9d0291aef97e2aab2334f62227083f3c32b85617 Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/google/dedede/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/47432/1
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 6da6505..bedca43 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -105,6 +105,10 @@ string default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb" if !BOARD_GOOGLE_DEDEDE
+config SOC_INTEL_CSE_RW_VERSION + string + default "13.50.0.1174" + config TPM_TIS_ACPI_INTERRUPT int default 4 # GPE0_DW0_4 (GPP_B4)
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47432 )
Change subject: mb/google/dedede: Add the CSE RW firmware version ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47432/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/47432/5/src/mainboard/google/dedede... PS5, Line 108: SOC_INTEL_CSE_RW_VERSION I think it would be better to set this in config.${BOARD} in chromiumos-overlay? That will allow us to add Cq-Depends directly between the uprev of CSE binary in private overlays and the update of this Kconfig. What do you think?
Also, as we are making this change to add RW metadata, I think it would be best to turn off the RW update feature for now. In the previous CL, I made a suggestion about adding a Kconfig for enabling RW update feature. If that is done, then by default we can keep the Kconfig disabled and only enable it after this patch series is pushed. Thoughts?
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47432 )
Change subject: mb/google/dedede: Add the CSE RW firmware version ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47432/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/47432/5/src/mainboard/google/dedede... PS5, Line 108: SOC_INTEL_CSE_RW_VERSION
I think it would be better to set this in config. […]
+1 to adding it in chromiumos-overlay. Also helps to avoid the downstreaming latency.
Sowmya V has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47432 )
Change subject: mb/google/dedede: Add the CSE RW firmware version ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47432/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/47432/5/src/mainboard/google/dedede... PS5, Line 108: SOC_INTEL_CSE_RW_VERSION
+1 to adding it in chromiumos-overlay. Also helps to avoid the downstreaming latency.
Initially even i was planning to set this config from chromium-overlay config file but then i thinking about the number of files that needs to be updated every time since every variant config needs to ne modified. Aligning with suggestion here that it is better to handle it from the overlays, will set this from the variant config files.
V Sowmya has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47432 )
Change subject: mb/google/dedede: Add the CSE RW firmware version ......................................................................
Abandoned
-
Furquan Shaikh (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Sowmya V (Code Review)
-
V Sowmya (Code Review)