Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 24:
(2 comments)
Just some random comments, I stumbled upon the libgfxinit+panel mention.
https://review.coreboot.org/c/coreboot/+/35523/24//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35523/24//COMMIT_MSG@21 PS24, Line 21: does not work at all with libgfxinit. I don't see any panel configuration in the devicetree[1]. The GOP does partial configuration based on the VBT, but doesn't set everything, AFAIK. Hence, I always advice to fill all applicable settings.
Um, just noticed the documentation doesn't mention the backlight PWM configuration. Which is most likely what is missing for libgfxinit support. Make sure to set `gpu_pch_backlight_pwm_hz` as well.
[1] https://doc.coreboot.org/gfx/display-panel.html
https://review.coreboot.org/c/coreboot/+/35523/24/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/24/src/mainboard/acer/aspire_... PS24, Line 18: select NO_POST # This platform has no way to see POST codes so disable them by default. Not that I personally use the option, but with this, one can't enable POST codes on the console anymore. Maybe a
config NO_POST default y
would serve better?