Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 7:
(2 comments)
Martin, thank you very much for your great ideas and suggestions - I'll try my best to implement them after I'll return from a vacation. Wish you to have a great time as well ;-)
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@277 PS7, Line 277: floppy_mass_downloader ()
Move to a separate script? This isn't really related to doing patches, and would be useful by itsel […]
After my return I'm going to work more on SeaBIOS "multiple_floppies" patch, and - after it gets merged successfully - could integrate this floppy part into coreboot's configuration menu, similar to "Secondary payloads". Until this time I'm a bit hesitant about moving, although could copy it (with its' dependencies) into a separate script.
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@765 PS7, Line 765: csb_mass_patcher
Instead of hardcoding these, it would be good to maybe pull them from a patch. […]
Although some things can't be pulled (i.e. SHA256), things like a diff filename - definitely could. Hope it can be done efficiently without adding many code lines (to keep this script smaller than 1k). I'll also try to create some interface for using this script with a different patches / patch sets, to make it more useful for the fellow coreboot'ers.