[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add UPD for support force USB3 to Gen1 by port

[chris wang (Code Review)]

chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45333 )

Change subject: soc/amd/picasso: Add UPD for support force USB3 to Gen1 by port
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45333/4/src/soc/amd/picasso/chip.h 
File src/soc/amd/picasso/chip.h:

https://review.coreboot.org/c/coreboot/+/45333/4/src/soc/amd/picasso/chip.h@... 
PS4, Line 158: 	uint8_t xhci0_force_gen1;
> How is this different than the newly added one?

for xhci0_force_gen1,it will set all port on xhci0 to gen1 but usb3_port_force_gen1 will set it by individual port.

https://review.coreboot.org/c/coreboot/+/45333/4/src/soc/amd/picasso/chip.h@... 
PS4, Line 172: usb3_port_force_gen1
> Ya. this doesn't seem per port unless it's a bitfield.

Done