Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49200 )
Change subject: mb/google/parrot: Let else statement follow closing brace
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/parrot/smihandler.c:
https://review.coreboot.org/c/coreboot/+/49200/comment/05584daf_9b2eedeb
PS1, Line 42: while (mainboard_smi_ec() != EC_NO_EVENT);
Personally, I'd add a newline here to separate both branches
Should be handled in a different patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49200
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1302e32b0d52e37d9cb4503128edc7d1df1c3bd8
Gerrit-Change-Number: 49200
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 08 Jan 2021 06:51:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment