Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38388 )
Change subject: soc/intel/{apl,cnl,icl,skl,tgl}: Add comments for above 4GB mem range macro ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
@Angle: do we need this CL or shall we abandon this ?
It's not strictly necessary (it's just adding comments). I haven't had much time to revisit it, but I like the idea. I wouldn't abandon it for now.
Thanks Angle if you could spent some time in next 2 week would be good. we have some tracker to check open CL and need to explain why. if we need this CL we will merge else i will abandon after 2 week checking with you
Hi Subrata,
I'm afraid I haven't had much time to revisit this change. I would abandon it for now, if it's needed it can be restored later.
Thanks Angel