Patch Set 2:

Patch Set 2:

Patch Set 2:

Patch Set 2:

@Angle: do we need this CL or shall we abandon this ?

It's not strictly necessary (it's just adding comments). I haven't had much time to revisit it, but I like the idea. I wouldn't abandon it for now.

Thanks Angle if you could spent some time in next 2 week would be good. we have some tracker to check open CL and need to explain why. if we need this CL we will merge else i will abandon after 2 week checking with you

Hi Subrata,

I'm afraid I haven't had much time to revisit this change. I would abandon it for now, if it's needed it can be restored later.

Thanks Angel

View Change

To view, visit change 38388. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe812031ea91932ec63adb030541b5ab5db8f425
Gerrit-Change-Number: 38388
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 25 Feb 2020 11:17:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment