Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )
Change subject: trogdor: Latch GPIO interrupt support ......................................................................
Patch Set 9:
(8 comments)
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/board.h:
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 29: GPIO_PULLNONE = 0,
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 29: GPIO_PULLNONE = 0,
These don't need to be here, just use GPIO_PULL_UP from <soc/gpio.h>. […]
Done
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 30: GPIO_PULLUP = 1,
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 30: GPIO_PULLUP = 1,
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 31: GPIO_PULLDOWN = 2,
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 31: GPIO_PULLDOWN = 2,
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 27: gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULLUP);
Sorry, on second thought, this should go into chromeos.c after all...
Done
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.c:
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 32: gpio_input_pullup(GPIO_H1_AP_INT);
...and replace this line here.
Done