Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45856 )
Change subject: soc/intel/jasperlake: Allow mainboard to override chip configuration ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45856/1/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45856/1/src/soc/intel/jasperlake/fs... PS1, Line 94: override
Maybe. I wouldn't know how to call it, though. […]
I don't have any better suggestions ATM either 😞
You are right, I think the reason is that the mainboard chip driver often gets forgotten. chip init is called in BS_DEV_INIT_CHIPS, and I believe it's guaranteed by the devtree model that the mainboard is the (one of anyway) first real device in `all_devices`, therefore this should be OK. FSP init is also called from chip init (of the SoC), which may be the reason why we've used these `mainboard_update` functions (otherwise you're relying on the fact that the mainboard is first in all_devices).