View Change

1 comment:

• File src/soc/intel/jasperlake/fsp_params.c:

  • Patch Set #1, Line 94: override

    Maybe. I wouldn't know how to call it, though. […]

    I don't have any better suggestions ATM either 😞

    You are right, I think the reason is that the mainboard chip driver often gets forgotten. chip init is called in BS_DEV_INIT_CHIPS, and I believe it's guaranteed by the devtree model that the mainboard is the (one of anyway) first real device in `all_devices`, therefore this should be OK.
    FSP init is also called from chip init (of the SoC), which may be the reason why we've used these `mainboard_update` functions (otherwise you're relying on the fact that the mainboard is first in all_devices).

To view, visit change 45856. To unsubscribe, or for help writing mail filters, visit settings.