Attention is currently required from: Angel Pons, Felix Held.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32604 )
Change subject: mb/apple: Add MacBook Air 5,2 (A1466) support ......................................................................
Patch Set 41:
(7 comments)
File src/mainboard/apple/macbookair5_2/Kconfig:
https://review.coreboot.org/c/coreboot/+/32604/comment/4a9ed4c1_b95031e9 PS23, Line 31: default "pci8086,0166.rom"
Not on this machine yet
Who wants VBIOS anyway, let's drop it.
File src/mainboard/apple/macbookair5_2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32604/comment/2eb4865c_2078965d PS36, Line 2: register "gfx.ndid" = "2"
This doesn't make sense if `gfx.did` is not specified.
Done
https://review.coreboot.org/c/coreboot/+/32604/comment/0819252f_f93a8133 PS36, Line 8: 1
PANEL_PORT_DP_A
Done
https://review.coreboot.org/c/coreboot/+/32604/comment/e71b4224_7f50962e PS36, Line 36: Intel Series 6 Cougar Point PCH
This board uses a 7 series Panther Point PCH
Done
https://review.coreboot.org/c/coreboot/+/32604/comment/dc126efd_eb6325f7 PS36, Line 42: register "pcie_port_coalesce" = "1"
Coalescing isn't needed when the first PCH PCIe RP (`device pci 1c.0`) is enabled.
Done
File src/mainboard/apple/macbookair5_2/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/32604/comment/108d5838_19de4817 PS1, Line 23: ports : constant Port_List :=
Some of these ports can be removed, if not in use.
Same answer.
File src/mainboard/apple/macbookair5_2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/32604/comment/60d37794_90d4bcb0 PS23, Line 29: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, : GMA_INT15_PANEL_FIT_DEFAULT, : GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
Is the VBIOS tested?
Done