Attention is currently required from: Angel Pons, Felix Held.

View Change

7 comments:

• File src/mainboard/apple/macbookair5_2/Kconfig:

  • Patch Set #23, Line 31: default "pci8086,0166.rom"

    Not on this machine yet

    Who wants VBIOS anyway, let's drop it.

• File src/mainboard/apple/macbookair5_2/devicetree.cb:

  • Patch Set #36, Line 2: register "gfx.ndid" = "2"

    This doesn't make sense if `gfx.did` is not specified.

    Done

  • Patch Set #36, Line 8: 1

    PANEL_PORT_DP_A

    Done

  • Patch Set #36, Line 36: Intel Series 6 Cougar Point PCH

    This board uses a 7 series Panther Point PCH

    Done

  • Patch Set #36, Line 42: register "pcie_port_coalesce" = "1"

    Coalescing isn't needed when the first PCH PCIe RP (`device pci 1c.0`) is enabled.

    Done

• File src/mainboard/apple/macbookair5_2/gma-mainboard.ads:

  • Patch Set #1, Line 23: ports : constant Port_List :=

    Some of these ports can be removed, if not in use.

    Same answer.

• File src/mainboard/apple/macbookair5_2/mainboard.c:

  • Patch Set #23, Line 29:

    install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP,
    		GMA_INT15_PANEL_FIT_DEFAULT,
    		GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
    

    Is the VBIOS tested?

    Done

To view, visit change 32604. To unsubscribe, or for help writing mail filters, visit settings.