Attention is currently required from: Karthik Ramasubramanian, Paul Menzel.
Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79976?usp=email )
Change subject: mb/google/dedede/var/galtic: Correct name for mem-part K4U6E3S4AA-MGCR ......................................................................
Patch Set 5: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79976/comment/35a62cad_f760c1bb : PS4, Line 7: Correct the Memory Part Name
Correct name for mem-part K4U6E3S4AA-MGCR
Done
https://review.coreboot.org/c/coreboot/+/79976/comment/62ef2823_5c4c7cba : PS4, Line 9: memtion
mentioned?
Done
https://review.coreboot.org/c/coreboot/+/79976/comment/7a45c587_dc570f1a : PS4, Line 11:
Please only one space.
Done
https://review.coreboot.org/c/coreboot/+/79976/comment/3ba234ec_367270b5 : PS4, Line 13:
How could this mistake happen? Was there a bug in the script?
I think no bug for script, and sorry that I don't know what's happened before. I iust take a look for coreboot section recently, and just pure run command "part_id_gen.go" after repo sync code on firmware-dedede-13606.B. Then found the problem.