Attention is currently required from: Karthik Ramasubramanian, Paul Menzel.
Patch set 5:Code-Review +1
View Change
4 comments:
Commit Message:
Patch Set #4, Line 7: Correct the Memory Part Name
Correct name for mem-part K4U6E3S4AA-MGCR
Done
Patch Set #4, Line 9: memtion
mentioned?
Done
Patch Set #4, Line 11:
Please only one space.
Done
Patch Set #4, Line 13:
How could this mistake happen? Was there a bug in the script?
I think no bug for script, and sorry that I don't know what's happened before.
I iust take a look for coreboot section recently, and just pure run command "part_id_gen.go" after repo sync code on firmware-dedede-13606.B. Then found the problem.
To view, visit change 79976. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c158eb7b4455cde839a335913e6a18895c12b41
Gerrit-Change-Number: 79976
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Peng <daniel_peng@pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng@pegatron.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang@google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen@google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Frank Chu <frank_chu@pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin@pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu@pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Comment-Date: Tue, 16 Jan 2024 01:29:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: comment