Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35540 )
Change subject: acpi_table_header: Replace hard-coded length via sizeof(acpi_fadt_t) ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35540/5/src/mainboard/amd/torpedo/f... File src/mainboard/amd/torpedo/fadt.c:
https://review.coreboot.org/c/coreboot/+/35540/5/src/mainboard/amd/torpedo/f... PS5, Line 53: ACPI_FADT_REV_ACPI_1_0
arch/acpi.h contains multiple macros for FADT Major Revisions as per the ACPI specification. […]
ACPI 1.0 has incompatibilities with later versions. Anything that's originally 2.0 or more recent can be updated to 6, so update get_acpi_table_revision to reflect that, but only use it when original hardcoded value is not 1.0. It should not be used here, as it's originally 1.0. Also, I do believe that updating get_acpi_table_revision should be a separate patch, does not belong to the current commit message.