1 comment:
File src/mainboard/amd/torpedo/fadt.c:
Patch Set #5, Line 53: ACPI_FADT_REV_ACPI_1_0
arch/acpi.h contains multiple macros for FADT Major Revisions as per the ACPI specification. […]
ACPI 1.0 has incompatibilities with later versions. Anything that's originally 2.0 or more recent can be updated to 6, so update get_acpi_table_revision to reflect that, but only use it when original hardcoded value is not 1.0. It should not be used here, as it's originally 1.0.
Also, I do believe that updating get_acpi_table_revision should be a separate patch, does not belong to the current commit message.
To view, visit change 35540. To unsubscribe, or for help writing mail filters, visit settings.