Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47154 )
Change subject: mb/google/dedede/variants/drawcia: Update Power Limit2 minimum value ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47154/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47154/1//COMMIT_MSG@7 PS1, Line 7: drawcia
It is not just drawcia that is being changed.
In this patch, modified for drawcia and baseboard. Please, suggest the appropriate one here. I checked all other JSL variants for this PL2 values. For madoo variant looks fine it's already 20W.
https://review.coreboot.org/c/coreboot/+/47154/1//COMMIT_MSG@9 PS1, Line 9: Update Power Limit2 minimum value to the same as maximum value.
Why? It would be good to capture the reason/motivation here.
The reason is that DTT (DPTF) does not throttle PL2, so need to set both max and min the same value. I see other variant Madoo sets it the same.
https://review.coreboot.org/c/coreboot/+/47154/1//COMMIT_MSG@13 PS1, Line 13: test
How? And what was the difference in behavior?
Using DTT GUI Tool verified these values. There should not be any difference in behavior.