View Change
3 comments:
Commit Message:
Patch Set #1, Line 7: drawcia
It is not just drawcia that is being changed.
In this patch, modified for drawcia and baseboard. Please, suggest the appropriate one here.
I checked all other JSL variants for this PL2 values. For madoo variant looks fine it's already 20W.
Patch Set #1, Line 9: Update Power Limit2 minimum value to the same as maximum value.
Why? It would be good to capture the reason/motivation here.
The reason is that DTT (DPTF) does not throttle PL2, so need to set both max and min the same value. I see other variant Madoo sets it the same.
Patch Set #1, Line 13: test
How? And what was the difference in behavior?
Using DTT GUI Tool verified these values. There should not be any difference in behavior.
To view, visit change 47154. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ecf1ffcc7871192ebe18eb8c3c3fd3e1193721e
Gerrit-Change-Number: 47154
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 03 Nov 2020 05:35:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Gerrit-MessageType: comment