Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35884 )
Change subject: soc/intel/Kconfig: Move MMCONF_BASE_ADDRESS out of a common place
......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 4: Code-Review-1
No. It doesn't make sense.
not sure to understand
anyway:
src/soc/intel/icelake/Kconfig will select SOC_INTEL_COMMON_BLOCK_SA but
MMCONF_BASE_ADDRESS = 0xc0000000
See the reason why `soc/intel/common/Kconfig.common` is named like that in "soc/intel/Kconfig": the common Kconfig options will be picked up last 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcfea1718cc36ae16b491604786c26c6ed320f06
Gerrit-Change-Number: 35884
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
d.guckian20@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Jul 2020 09:09:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment