Patch Set 4:

Patch Set 4: Code-Review-1

No. It doesn't make sense.

not sure to understand

src/soc/intel/icelake/Kconfig will select SOC_INTEL_COMMON_BLOCK_SA but

See the reason why `soc/intel/common/Kconfig.common` is named like that in "soc/intel/Kconfig": the common Kconfig options will be picked up last 😊

View Change

To view, visit change 35884. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcfea1718cc36ae16b491604786c26c6ed320f06
Gerrit-Change-Number: 35884
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <>
Gerrit-Reviewer: Aaron Durbin <>
Gerrit-Reviewer: Andrey Petrov <>
Gerrit-Reviewer: Angel Pons <>
Gerrit-Reviewer: Arthur Heymans <>
Gerrit-Reviewer: David Guckian <>
Gerrit-Reviewer: David Guckian <>
Gerrit-Reviewer: HAOUAS Elyes <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: Vanessa Eusebio <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Nico Huber <>
Gerrit-CC: Paul Menzel <>
Gerrit-Comment-Date: Thu, 23 Jul 2020 09:09:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment