Name of user not set #1002358 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support ......................................................................
Patch Set 6:
(17 comments)
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@256 PS5, Line 256: break;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@256 PS5, Line 256: break;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@256 PS5, Line 256: break;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@340 PS5, Line 340:
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@340 PS5, Line 340:
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@433 PS5, Line 433: Resource->PciCfg.PciDevicePath[0].PciFunction);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@434 PS5, Line 434: if (Resource->Header.Length !=
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@442 PS5, Line 442: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice >
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@444 PS5, Line 444: (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction >
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@747 PS5, Line 747: MinMsegSize = (STM_PAGES_TO_SIZE(STM_SIZE_TO_PAGES(StmHeader->SwStmHdr.StaticImageSize))
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@749 PS5, Line 749: + (StmHeader->SwStmHdr.PerProcDynamicMemorySize
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@846 PS5, Line 846: (void *)StmImage, // HashData
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@846 PS5, Line 846: (void *)StmImage, // HashData
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/5/src/security/intel/stm/SmmStm.c@846 PS5, Line 846: (void *)StmImage, // HashData
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@442 PS6, Line 442: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice >
line over 80 characters
How does one deal with statements that really cannot be split
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@444 PS6, Line 444: (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction >
line over 80 characters
How does one deal with statements that cannot be split
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@748 PS6, Line 748: (STM_PAGES_TO_SIZE(STM_SIZE_TO_PAGES(StmHeader->SwStmHdr.StaticImageSize))
line over 80 characters
How does one deal with statements that really cannot be split