17 comments:
File src/security/intel/stm/SmmStm.c:
Patch Set #5, Line 256: break;
please, no space before tabs
Done
Patch Set #5, Line 256: break;
code indent should use tabs where possible
Done
Patch Set #5, Line 256: break;
please, no spaces at the start of a line
Done
please, no spaces at the start of a line
Done
trailing whitespace
Done
Patch Set #5, Line 433: Resource->PciCfg.PciDevicePath[0].PciFunction);
line over 80 characters
Done
Patch Set #5, Line 434: if (Resource->Header.Length !=
trailing whitespace
Done
Patch Set #5, Line 442: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice >
line over 80 characters
Done
Patch Set #5, Line 444: (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction >
line over 80 characters
Done
Patch Set #5, Line 747: MinMsegSize = (STM_PAGES_TO_SIZE(STM_SIZE_TO_PAGES(StmHeader->SwStmHdr.StaticImageSize))
line over 80 characters
Done
Patch Set #5, Line 749: + (StmHeader->SwStmHdr.PerProcDynamicMemorySize
trailing whitespace
Done
Patch Set #5, Line 846: (void *)StmImage, // HashData
code indent should use tabs where possible
Done
Patch Set #5, Line 846: (void *)StmImage, // HashData
please, no space before tabs
Done
Patch Set #5, Line 846: (void *)StmImage, // HashData
please, no spaces at the start of a line
Done
File src/security/intel/stm/SmmStm.c:
Patch Set #6, Line 442: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice >
line over 80 characters
How does one deal with statements that really cannot be split
Patch Set #6, Line 444: (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction >
line over 80 characters
How does one deal with statements that cannot be split
Patch Set #6, Line 748: (STM_PAGES_TO_SIZE(STM_SIZE_TO_PAGES(StmHeader->SwStmHdr.StaticImageSize))
line over 80 characters
How does one deal with statements that really cannot be split
To view, visit change 33234. To unsubscribe, or for help writing mail filters, visit settings.