[coreboot-gerrit] Change in coreboot[master]: console: Override coreboot log level via VPD variable

[Johnny Lin (Code Review)]

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45134 )

Change subject: console: Override coreboot log level via VPD variable
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45134/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45134/7//COMMIT_MSG@12 
PS7, Line 12: the log level will be set to CONFIG_DEFAULT_CONSOLE_LOGLEVEL.
> Please read Nico’s comment. […]

So I should move the get_console_loglevel() into get_option() to unify the function interface, right? My question is in
src/console/init.c get_log_level(), get_option() seems cannot be used when CONSOLE_LEVEL_CONST is true, it doesn't boot. Also it can be very inefficient because this function got called in each printk and it tries to read cmos every time, any suggestion? Thanks.
 -       if (CONSOLE_LEVEL_CONST)
 -               return get_console_loglevel();
 +       if (CONSOLE_LEVEL_CONST) {
 +               int debug_level = CONFIG_DEFAULT_CONSOLE_LOGLEVEL;
 +               get_option(&debug_level, "debug_level");
 +               return debug_level;
 +       }