View Change
1 comment:
Commit Message:
Patch Set #7, Line 12: the log level will be set to CONFIG_DEFAULT_CONSOLE_LOGLEVEL.
Please read Nico’s comment. […]
So I should move the get_console_loglevel() into get_option() to unify the function interface, right? My question is in
src/console/init.c get_log_level(), get_option() seems cannot be used when CONSOLE_LEVEL_CONST is true, it doesn't boot. Also it can be very inefficient because this function got called in each printk and it tries to read cmos every time, any suggestion? Thanks.
- if (CONSOLE_LEVEL_CONST)
- return get_console_loglevel();
+ if (CONSOLE_LEVEL_CONST) {
+ int debug_level = CONFIG_DEFAULT_CONSOLE_LOGLEVEL;
+ get_option(&debug_level, "debug_level");
+ return debug_level;
+ }
To view, visit change 45134. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278e392bed178df7a8cdb90685963c1fedf0bcc4
Gerrit-Change-Number: 45134
Gerrit-PatchSet: 7
Gerrit-Owner: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu@wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang@wiwynn.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: insomniac <insomniac@slackware.it>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 18 Sep 2020 15:18:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment