Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32531 )
Change subject: Add support for the 51nb X210 ......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/#/c/32531/21/src/mainboard/51nb/x210/pei_data.c File src/mainboard/51nb/x210/pei_data.c:
https://review.coreboot.org/#/c/32531/21/src/mainboard/51nb/x210/pei_data.c@... PS21, Line 59: void mainboard_fill_pei_data(struct pei_data *pei_data) : { : mainboard_fill_dq_map_data(&pei_data->dq_map); : mainboard_fill_dqs_map_data(&pei_data->dqs_map); : mainboard_fill_rcomp_res_data(&pei_data->RcompResistor); : mainboard_fill_rcomp_strength_data(&pei_data->RcompTarget); : }
Are these functions really used? I just searched the coreboot tree after them, but haven't found any […]
Not sure what you mean. The implementations above are only used in the mainboard code, yes. But also in `romstage.c` where FSP is effectively configured.
If you meant the mainboard_fill_pei_data() implementations, they are called from SoC level, but only to pass the data to mainboard_memory_ init_params() back later. That's what I called code talking to itself (via somebody else' struct). It's too weird, I try to get rid of it: topic:no_pei_data_hoops let's see if something compiles ^^