Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33102 )
Change subject: ec/apple: Add ACPI code for Apple MacBooks ......................................................................
Patch Set 13:
(8 comments)
https://review.coreboot.org/c/coreboot/+/33102/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33102/13//COMMIT_MSG@10 PS13, Line 10: it's Please use possesive "its"
Also, please indent the line with two spaces
https://review.coreboot.org/c/coreboot/+/33102/10/src/ec/apple/acpi/ac_01.as... File src/ec/apple/acpi/ac_01.asl:
PS10:
ac_01/60 and lid_01/60 could easily be merged. All you'd […]
Still unresolved
https://review.coreboot.org/c/coreboot/+/33102/10/src/ec/apple/acpi/ac_01.as... PS10, Line 34: return(HPAC)
Return
Still unresolved
https://review.coreboot.org/c/coreboot/+/33102/10/src/ec/apple/acpi/ac_60.as... File src/ec/apple/acpi/ac_60.asl:
https://review.coreboot.org/c/coreboot/+/33102/10/src/ec/apple/acpi/ac_60.as... PS10, Line 34: return(HPAC)
Return
Still unresolved
https://review.coreboot.org/c/coreboot/+/33102/10/src/ec/apple/acpi/ec.asl File src/ec/apple/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/33102/10/src/ec/apple/acpi/ec.asl@4... PS10, Line 42: IO
FixedIO instead of IO could be used for these two
Still unresolved
https://review.coreboot.org/c/coreboot/+/33102/10/src/ec/apple/acpi/ec.asl@5... PS10, Line 50: return (Package () { 0x23, 0x04 })
This is the same as in lid_60 so I guess the _PRW method […]
Still unresolved
https://review.coreboot.org/c/coreboot/+/33102/10/src/ec/apple/acpi/lid_01.a... File src/ec/apple/acpi/lid_01.asl:
https://review.coreboot.org/c/coreboot/+/33102/10/src/ec/apple/acpi/lid_01.a... PS10, Line 34: return(LIDS)
Return
Still unresolved
https://review.coreboot.org/c/coreboot/+/33102/10/src/ec/apple/acpi/lid_01.a... PS10, Line 39: Return (Package() { 0x1d, 0x03 })
This would need `gpi13_routing = 2` in the devicetree, I guess.
Still unresolved