8 comments:
Please use possesive "its"
Also, please indent the line with two spaces
File src/ec/apple/acpi/ac_01.asl:
ac_01/60 and lid_01/60 could easily be merged. All you'd […]
Still unresolved
Patch Set #10, Line 34: return(HPAC)
Return
Still unresolved
File src/ec/apple/acpi/ac_60.asl:
Patch Set #10, Line 34: return(HPAC)
Return
Still unresolved
File src/ec/apple/acpi/ec.asl:
FixedIO instead of IO could be used for these two
Still unresolved
Patch Set #10, Line 50: return (Package () { 0x23, 0x04 })
This is the same as in lid_60 so I guess the _PRW method […]
Still unresolved
File src/ec/apple/acpi/lid_01.asl:
Patch Set #10, Line 34: return(LIDS)
Return
Still unresolved
Patch Set #10, Line 39: Return (Package() { 0x1d, 0x03 })
This would need `gpi13_routing = 2` in the devicetree, I guess.
Still unresolved
To view, visit change 33102. To unsubscribe, or for help writing mail filters, visit settings.