Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32905 )
Change subject: RFC: smbios: allow setting BIOS version string from VPD variable ......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 3:
Please explain why it should be useful. Why does CONFIG_LOCALVERSION not work for you. If you can read VPD from OS, why do you need to provide the information in smbios tables?
We do have a lot of software that rely on SMBIOS and is not easily / not possible to modify. This also allows to have a compatibility layer with older / not maintained anymore / closed source software that rely on information in SMBIOS.
That's a good argument, that should be added to the commit message to explain why the change is done. It doesn't explain why it needs to be runtime configurable and why CONFIG_LOCALVERSION doesn't work for you.