Patch Set 4:

Patch Set 3:

Please explain why it should be useful. Why does CONFIG_LOCALVERSION not work for you. If you can read VPD from OS, why do you need to provide the information in smbios tables?

We do have a lot of software that rely on SMBIOS and is not easily / not possible to modify. This also allows to have a compatibility layer with older / not maintained anymore / closed source software that rely on information in SMBIOS.

That's a good argument, that should be added to the commit message to explain why the change is done. It doesn't explain why it needs to be runtime configurable and why CONFIG_LOCALVERSION doesn't work for you.

View Change

To view, visit change 32905. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0e9d90ed0941c4e76e3e48cdcccf830ef789458
Gerrit-Change-Number: 32905
Gerrit-PatchSet: 4
Gerrit-Owner: Łukasz Siudut
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: Łukasz Siudut
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-CC: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Fri, 21 Jun 2019 14:15:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment