Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44507 )
Change subject: soc/intel/apl: Add ACPI for SMBus control ......................................................................
Patch Set 4:
(2 comments)
Thanks for the review
https://review.coreboot.org/c/coreboot/+/44507/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44507/2//COMMIT_MSG@7 PS2, Line 7: SBMBUS
Is SBM in here correct?
Fixed
https://review.coreboot.org/c/coreboot/+/44507/2//COMMIT_MSG@11 PS2, Line 11:
Tested how?
TEST = After loading the nct7802 module on the Kontron mAL10 with Linux OS, we can read the hwm registers, see temperature and fan speed
Also a new i2c device appears in /sys/bus/i2c/devices and the nct7802 module uses it.
nct7802-i2c-0-2e -> i2c-0 Adapter: SMBus CMI adapter cmi
Before that, the module could not see the hwm device.