Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44507 ) Change subject: soc/intel/apl: Add ACPI for SMBus control ...................................................................... Patch Set 4: (2 comments) Thanks for the review https://review.coreboot.org/c/coreboot/+/44507/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/44507/2//COMMIT_MSG@7 PS2, Line 7: SBMBUS
Is SBM in here correct? Fixed
https://review.coreboot.org/c/coreboot/+/44507/2//COMMIT_MSG@11 PS2, Line 11:
Tested how? TEST = After loading the nct7802 module on the Kontron mAL10 with Linux OS, we can read the hwm registers, see temperature and fan speed
Also a new i2c device appears in /sys/bus/i2c/devices and the nct7802 module uses it. nct7802-i2c-0-2e -> i2c-0 Adapter: SMBus CMI adapter cmi Before that, the module could not see the hwm device. -- To view, visit https://review.coreboot.org/c/coreboot/+/44507 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3846266d3155bbe831123fef4751748ff0e00511 Gerrit-Change-Number: 44507 Gerrit-PatchSet: 4 Gerrit-Owner: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 28 Aug 2020 10:11:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment