Attention is currently required from: Nico Huber, Eugene Myers, Benjamin Doron, Paul Menzel, Michael Niewöhner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 194: Verified-1
(13 comments)
File src/mainboard/acer/aspire_vn7_572g/Kconfig:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/5c21b08a_3d02461b PS194, Line 22: select NO_UART_ON_SUPERIO 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/e308bf9c_cc01ca7a PS194, Line 45: if (data_buffer <= (2017 / ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/fdec8266_a0a8baa0 PS194, Line 302: | LPC_IOE_EC_62_66 | LPC_IOE_SUPERIO_2E_2F | LPC_IOE_EC_4E_4F" # 82h-83h 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/acer/aspire_vn7_572g/die.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/1d142296_59527b37 PS194, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/8a36d659_6b5df5ec PS194, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/3ff56d6a_ace13e40 PS194, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/0066f889_1bf09288 PS194, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/24aab0bd_6dccf11b PS194, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/f46057df_ba845dd6 PS194, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/afb99d95_0db95f6f PS194, Line 98: if (dat & 1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/4b719932_0575f1ad PS194, Line 122: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/d63e32b6_5e7da04a PS194, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135582): https://review.coreboot.org/c/coreboot/+/35523/comment/ccf6cc83_8b8e55a0 PS194, Line 160: if (gnvs) { braces {} are not necessary for single statement blocks