Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34883 )
Change subject: [WIP] amd/stoneyridge: Fix CAR stack location ......................................................................
Patch Set 1:
did you come across some stale comments about it or why did you bring it up here? Because it was the reason for Jenkins to give you a -1...
Ahh.. that Jenkins -1 was some bug on previous commits on this branch. They were on intel...
and because I did came across it with a code I was developing, though it did work (and booted) when building locally. But when I tried in a google environment, it would fail to build. All I was doing was declaring a structure in one file and declaring it as external in 2 other files.
We recently flipped from NO_CAR_GLOBAL_MIGRATION to CAR_GLOBAL_MIGRATION Kconfig in upstream. If you move board to older branch you probably have to put 'select NO_CAR_GLOBAL_MIGRATION' or 'select POSTCAR_STAGE' lines back in the board Kconfig. Having that wrong would trigger those forbidden globals in romstage -errors.