did you come across some stale comments about it or why did you bring it up here? Because it was the reason for Jenkins to give you a -1...

Ahh.. that Jenkins -1 was some bug on previous commits on this branch. They were on intel...

and because I did came across it with a code I was developing, though it did work (and booted)
when building locally. But when I tried in a google environment, it would fail to build. All I
was doing was declaring a structure in one file and declaring it as external in 2 other files.

We recently flipped from NO_CAR_GLOBAL_MIGRATION to CAR_GLOBAL_MIGRATION Kconfig in upstream. If you move board to older branch you probably have to put 'select NO_CAR_GLOBAL_MIGRATION' or 'select POSTCAR_STAGE' lines back in the board Kconfig. Having that wrong would trigger those forbidden globals in romstage -errors.

View Change

To view, visit change 34883. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id91393f1e7faf86b01fdc113e7940893673a27a7
Gerrit-Change-Number: 34883
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 21 Aug 2019 15:51:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment