Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38482 )
Change subject: mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38482/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38482/3//COMMIT_MSG@10 PS3, Line 10: CB:34361 What about the differences in hda_verb.c and devicetree?
https://review.coreboot.org/c/coreboot/+/38482/3/src/mainboard/lenovo/x230/K... File src/mainboard/lenovo/x230/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/38482/3/src/mainboard/lenovo/x230/K... PS3, Line 2: bool "ThinkPad X230 / X230t" Note that the mainboard name (the one that appears in SMBIOS/DMI tables) is still "Thinkpad X230" for both variants.
If the differences in devicetrees and hda_verb.c configs have to be taken into account, then the boards would have to be variants.