Change in coreboot[master]: mb/lenovo/x230: Add Lenovo X230 Tablet to the list of X230 variants
Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38482 )
Change subject: mb/lenovo/x230: Add Lenovo X230 Tablet to the list of X230 variants ......................................................................
mb/lenovo/x230: Add Lenovo X230 Tablet to the list of X230 variants
Lenovo ThinkPad X230t Convertible Laptop works well with X230 default image (see CB:34361).
Change-Id: Ib0a73fd551f0d26c789d3fd13541b2d1571742cb Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/x230/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/38482/1
diff --git a/src/mainboard/lenovo/x230/Kconfig.name b/src/mainboard/lenovo/x230/Kconfig.name index d207653..4f02d55 100644 --- a/src/mainboard/lenovo/x230/Kconfig.name +++ b/src/mainboard/lenovo/x230/Kconfig.name @@ -1,2 +1,2 @@ config BOARD_LENOVO_X230 - bool "ThinkPad X230" + bool "ThinkPad X230 / X230t"
Hello Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38482
to look at the new patch set (#2).
Change subject: mb/lenovo/x230: Add Lenovo X230t convertible/tablet to the list of X230 variants ......................................................................
mb/lenovo/x230: Add Lenovo X230t convertible/tablet to the list of X230 variants
Lenovo ThinkPad X230t Convertible Laptop works well with X230 default image (see CB:34361).
Change-Id: Ib0a73fd551f0d26c789d3fd13541b2d1571742cb Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/x230/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/38482/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38482 )
Change subject: mb/lenovo/x230: Add Lenovo X230t convertible/tablet to the list of X230 variants ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38482/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38482/2//COMMIT_MSG@7 PS2, Line 7: mb/lenovo/x230: Add Lenovo X230t convertible/tablet to the list of X230 variants Removing *the* makes it shorter. But maybe:
mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant
Hello Alexander Couzens, Patrick Rudolph, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38482
to look at the new patch set (#3).
Change subject: mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant ......................................................................
mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant
Lenovo ThinkPad X230t Convertible Laptop works well with X230 default image (see CB:34361).
Change-Id: Ib0a73fd551f0d26c789d3fd13541b2d1571742cb Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/x230/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/38482/3
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38482 )
Change subject: mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38482/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38482/2//COMMIT_MSG@7 PS2, Line 7: mb/lenovo/x230: Add Lenovo X230t convertible/tablet to the list of X230 variants
Removing *the* makes it shorter. But maybe: […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38482 )
Change subject: mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38482/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38482/3//COMMIT_MSG@10 PS3, Line 10: CB:34361 What about the differences in hda_verb.c and devicetree?
https://review.coreboot.org/c/coreboot/+/38482/3/src/mainboard/lenovo/x230/K... File src/mainboard/lenovo/x230/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/38482/3/src/mainboard/lenovo/x230/K... PS3, Line 2: bool "ThinkPad X230 / X230t" Note that the mainboard name (the one that appears in SMBIOS/DMI tables) is still "Thinkpad X230" for both variants.
If the differences in devicetrees and hda_verb.c configs have to be taken into account, then the boards would have to be variants.
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38482 )
Change subject: mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38482/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38482/3//COMMIT_MSG@10 PS3, Line 10: CB:34361 It was said that hda_verb are the same for both boards:
Both azalia (intel hda) area and PCIe routing are the same between comet-2 and dasher-2
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38482 )
Change subject: mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38482/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38482/3//COMMIT_MSG@10 PS3, Line 10: CB:34361
It was said that hda_verb are the same for both boards: […]
Devicetree from CB:34361 has the following differences:
1. No wwan bits which is likely an error since x230t does have wwan support (according to the product page)
2. Different pcie_hotplug_map which could be an error as well.
3. register value for "eventb_enable" is diffferent for x230t. Don't know what it means.
https://review.coreboot.org/c/coreboot/+/38482/3/src/mainboard/lenovo/x230/K... File src/mainboard/lenovo/x230/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/38482/3/src/mainboard/lenovo/x230/K... PS3, Line 2: bool "ThinkPad X230 / X230t"
Note that the mainboard name (the one that appears in SMBIOS/DMI tables) is still "Thinkpad X230" fo […]
Done. Changed MAINBOARD_PART_NUMBER in case of x230t.
Hello build bot (Jenkins), Paul Menzel, Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38482
to look at the new patch set (#4).
Change subject: mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant ......................................................................
mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant
Lenovo ThinkPad X230t Convertible Laptop works well with X230 default image (see CB:34361).
Change-Id: Ib0a73fd551f0d26c789d3fd13541b2d1571742cb Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name 2 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/38482/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38482 )
Change subject: mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38482 )
Change subject: mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant ......................................................................
mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant
Lenovo ThinkPad X230t Convertible Laptop works well with X230 default image (see CB:34361).
Change-Id: Ib0a73fd551f0d26c789d3fd13541b2d1571742cb Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38482 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name 2 files changed, 7 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index bf70950..73dfdf6 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -1,4 +1,4 @@ -if BOARD_LENOVO_X230 +if BOARD_LENOVO_X230 || BOARD_LENOVO_X230T
config BOARD_SPECIFIC_OPTIONS def_bool y @@ -52,7 +52,8 @@
config MAINBOARD_PART_NUMBER string - default "ThinkPad X230" + default "ThinkPad X230" if BOARD_LENOVO_X230 + default "ThinkPad X230t" if BOARD_LENOVO_X230T
config MAX_CPUS int @@ -74,4 +75,4 @@ string default "8086,0166"
-endif # BOARD_LENOVO_X230 +endif # BOARD_LENOVO_X230 || BOARD_LENOVO_X230T diff --git a/src/mainboard/lenovo/x230/Kconfig.name b/src/mainboard/lenovo/x230/Kconfig.name index d207653..10fdc2e 100644 --- a/src/mainboard/lenovo/x230/Kconfig.name +++ b/src/mainboard/lenovo/x230/Kconfig.name @@ -1,2 +1,5 @@ config BOARD_LENOVO_X230 bool "ThinkPad X230" + +config BOARD_LENOVO_X230T + bool "ThinkPad X230t"
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Peter Lemenkov (Code Review)