Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 108:
(3 comments)
If anyone wants to take a look, I have the following logs:
cbmem: https://gist.github.com/benjamindoron/a70f1c6ad235d31baa02202139ea785c dmesg: https://gist.github.com/benjamindoron/c1290fe36616f06b70ad362f06b37e68
https://review.coreboot.org/c/coreboot/+/35523/81//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35523/81//COMMIT_MSG@26 PS81, Line 26: a customised KBL VBT
Copied the details manually this time and here are my notes: […]
Resolution may be a payload issue.
Marking as done.
https://review.coreboot.org/c/coreboot/+/35523/105//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35523/105//COMMIT_MSG@28 PS105, Line 28: dGPU
As FSP does display configuration (iGFX, Switchable Graphics, etc) in FSP-M and UEFI configures the […]
I had been sure that I had tried Display_Switchable before and that it didn't work, but it is working now. Perhaps the issue then was a different one (poorly configured VBT, maybe?).
I did not need to set any UPDs for Switchable Graphics GPIOs.
https://review.coreboot.org/c/coreboot/+/35523/95/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/95/src/mainboard/acer/aspire_... PS95, Line 17: select MAINBOARD_HAS_CRB_TPM : select MAINBOARD_HAS_TPM2 : # select HAVE_INTEL_PTT
Schematics mention the Nuvoton NPCT650, a TPM that exists in 1.2 and 2. […]
Board does not have a TPM in the region marked for one on the boardview.
Perhaps this is an issue of different models.