Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34752 )
Change subject: arch/x86: Attempt to boot without postcar stage/phase ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34752/6/src/arch/x86/c_start.S File src/arch/x86/c_start.S:
https://review.coreboot.org/c/coreboot/+/34752/6/src/arch/x86/c_start.S@19 PS6, Line 19: #endif
Can't this be included below at line 45 unconditionally? That was my suggestion.
exit_car.S to do car tear down which will be handled by postcar in regular flow, hence keeping #include "exit_car.S" unconditionally below at 45 won't be duplicate if that effort? (in case romstage -> postcar (exit_car.S) -> ramstage (exit_car.S))
I was also curious if we could define the same symbol twice w/o the assembler complaining.
i hope you meant _start symbol?, we can do that but problem is that _start already existed inside exit_car.S hence it will give compilation issue.
1. romstage -> postcar -> ramstage model postcar entry point is exit_car.S ramstage entry point is c_start.S
but 2. romstage -> ramstage model
we need to do tear down hence exit_car.S is added as first entry point now adding c_start.S also add another _start symbol
https://review.coreboot.org/c/coreboot/+/34752/6/src/arch/x86/exit_car.S File src/arch/x86/exit_car.S:
https://review.coreboot.org/c/coreboot/+/34752/6/src/arch/x86/exit_car.S@37 PS6, Line 37: Incase
in case
Done
https://review.coreboot.org/c/coreboot/+/34752/6/src/arch/x86/exit_car.S@38 PS6, Line 38: * be handled inside c_start.S hence avoiding dual GDT programming here
We'd be reliant on the descriptor cache. […]
Done
https://review.coreboot.org/c/coreboot/+/34752/6/src/arch/x86/include/arch/c... File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/34752/6/src/arch/x86/include/arch/c... PS6, Line 355:
unnecessary edit
Done