4 comments:
Patch Set #6, Line 19: #endif
Can't this be included below at line 45 unconditionally? That was my suggestion.
exit_car.S to do car tear down which will be handled by postcar in regular flow, hence keeping #include "exit_car.S" unconditionally below at 45 won't be duplicate if that effort? (in case romstage -> postcar (exit_car.S) -> ramstage (exit_car.S))
I was also curious if we could define the same symbol twice w/o the assembler complaining.
i hope you meant _start symbol?, we can do that but problem is that _start already existed inside exit_car.S hence it will give compilation issue.
1. romstage -> postcar -> ramstage model
postcar entry point is exit_car.S
ramstage entry point is c_start.S
but
2. romstage -> ramstage model
we need to do tear down hence exit_car.S is added as first entry point now adding c_start.S also add another _start symbol
Patch Set #6, Line 37: Incase
in case
Done
Patch Set #6, Line 38: * be handled inside c_start.S hence avoiding dual GDT programming here
We'd be reliant on the descriptor cache. […]
Done
File src/arch/x86/include/arch/cpu.h:
unnecessary edit
Done
To view, visit change 34752. To unsubscribe, or for help writing mail filters, visit settings.